Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Remove Export option for Zcash accounts

In release notes Bug Addresses, accounts & memos

Lead item brave-browser#35849 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#22120 merged 2024-02-20 into master by Douglashdaniel
    fix(wallet): Remove ZEC and BTC Export Option
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

  • Desktop 1.63.165: “Removed "Export" option for both Zcash and BTC accounts. (#35849)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.63.x - Release #3

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...3507fbb7: behind); later builds of the same history include it (brave-core#22120)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...3507fbb7: behind); later builds of the same history include it (brave-core#22120)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...3507fbb7: behind); later builds of the same history include it (brave-core#22120)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...3507fbb7: behind); later builds of the same history include it (brave-core#22120)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...3507fbb7: behind); later builds of the same history include it (brave-core#22120)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...3507fbb7: behind); later builds of the same history include it (brave-core#22120)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...3507fbb7: behind); later builds of the same history include it (brave-core#22120)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...3507fbb7: behind); later builds of the same history include it (brave-core#22120)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...3507fbb7: behind); later builds of the same history include it (brave-core#22120)

Members and their history

Issue

brave-browser#35849 Remove Export option for Zcash accounts

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash, search:zec · matched label:feature/web3/wallet/zcash, title:zcash, body:zcash

bug QA Pass-Win64 QA/Yes release-notes/include feature/web3/wallet OS/Desktop front-end-change feature/web3/wallet/bitcoin feature/web3/wallet/zcash

Description Remove Export option for Zcash accounts Steps to Reproduce 1. Enable flag and create a Zcash account 2. Open Accounts tab and select Zcash 3. Click on account menu, shows Export which should not be shown Actual result: [image] Expected result: No export option similar to BTC Reproduces how often: Easy Brave version (brave://version info) Brave | 1.64.51 Chromium: 121.0.6167.139 (Official Build) nightly (64-bit) -- | -- Revision |…

Timeline (16 of 21 events)
  1. 2024-02-07 10:03 Label added QA/Yes by srirambv
  2. 2024-02-07 10:03 Label added OS/Desktop by srirambv
  3. 2024-02-16 15:20 Referenced by brave-core#22120 by Douglashdaniel
  4. 2024-02-16 15:20 Label added release-notes/exclude by Douglashdaniel
  5. 2024-02-20 22:47 Closed completed brave-core#22120 by Douglashdaniel
  6. 2024-02-20 22:48 Milestone set 1.65.x - Nightly by brave-builds
  7. 2024-02-27 23:33 Milestone removed 1.65.x - Nightly by brave-builds
  8. 2024-02-27 23:33 Milestone set 1.64.x - Beta by brave-builds
  9. 2024-02-27 23:33 Referenced by brave-core#22352 by kjozwiak
  10. 2024-02-27 23:33 Referenced by brave-core#22353 by kjozwiak
  11. 2024-02-27 23:34 Milestone removed 1.64.x - Beta by brave-builds
  12. 2024-02-27 23:34 Milestone set 1.63.x - Release #3 by brave-builds
  13. 2024-02-27 23:34 Label removed release-notes/exclude by kjozwiak
  14. 2024-02-27 23:34 Label added release-notes/include by kjozwiak
  15. 2024-02-28 05:31 Label added QA Pass-Win64 by srirambv
  16. 2024-02-28 16:04 Referenced by brave-browser#36437 by LaurenWags
Pull request

brave-core#22120 fix(wallet): Remove ZEC and BTC Export Option

State: merged 2024-02-20 · created · closed · updated · discovered via search:zcash is:pr, search:zec is:pr · matched title:zec, body:zec

CI/storybook-url feature/web3/wallet

Description Removes the Export button option for ZEC and BTC on the Account Details page. Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup" commits before merge, so that history…

Timeline (6 of 8 events)
  1. 2024-02-20 22:47 Merged master by Douglashdaniel
  2. 2024-02-20 22:47 Closed by Douglashdaniel
  3. 2024-02-20 22:48 Milestone set 1.65.x - Nightly by github-actions
  4. 2024-02-27 20:52 Referenced by brave-core#22352 by brave-builds
  5. 2024-02-27 20:52 Referenced by brave-core#22353 by brave-builds
  6. 2024-02-28 05:31 Referenced by brave-browser#35849 by srirambv
Uplift PR → 1.63.x

brave-core#22353 fix(wallet): Remove ZEC and BTC Export Option (uplift to 1.63.x)

State: merged 2024-02-27 · created · closed · updated · discovered via search:zec is:pr · matched title:zec

CI/storybook-url feature/web3/wallet

- Uplift of #22120 - Resolves https://github.com/brave/brave-browser/issues/35849 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 5 events)
  1. 2024-02-27 20:52 Milestone set 1.63.x - Release #3 by brave-builds
  2. 2024-02-27 23:33 Merged 1.63.x by kjozwiak
  3. 2024-02-27 23:33 Closed by kjozwiak
Uplift PR → 1.64.x

brave-core#22352 fix(wallet): Remove ZEC and BTC Export Option (uplift to 1.64.x)

State: merged 2024-02-27 · created · closed · updated · discovered via search:zec is:pr · matched title:zec

CI/storybook-url feature/web3/wallet

- Uplift of #22120 - Resolves https://github.com/brave/brave-browser/issues/35849 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 5 events)
  1. 2024-02-27 20:52 Milestone set 1.64.x - Beta by brave-builds
  2. 2024-02-27 23:32 Merged 1.64.x by kjozwiak
  3. 2024-02-27 23:32 Closed by kjozwiak