Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

ZEC addresses and additional details can be hard to see in dark mode

In release notes Issue Addresses, accounts & memos

Lead item brave-browser#35827 · opened by kdenhartog · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#24375 merged 2024-06-25 into master by Douglashdaniel
    style(wallet): Confirm ZCash Transaction Details Text
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.69.153: “Improved display of ZEC addresses and additional details when using dark theme. (#35827)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.69.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...5276a2e7: behind); later builds of the same history include it (brave-core#24375)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...5276a2e7: behind); later builds of the same history include it (brave-core#24375)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...5276a2e7: behind); later builds of the same history include it (brave-core#24375)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...5276a2e7: behind); later builds of the same history include it (brave-core#24375)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...5276a2e7: behind); later builds of the same history include it (brave-core#24375)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...5276a2e7: behind); later builds of the same history include it (brave-core#24375)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...5276a2e7: behind); later builds of the same history include it (brave-core#24375)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...5276a2e7: behind); later builds of the same history include it (brave-core#24375)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...5276a2e7: behind); later builds of the same history include it (brave-core#24375)

Members and their history

Issue

brave-browser#35827 ZEC addresses and additional details can be hard to see in dark mode

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zec · matched label:feature/web3/wallet/zcash, title:zec, body:zec

QA Pass-Win64 priority/P3 QA/Yes release-notes/include feature/web3/wallet OS/Desktop front-end-change feature/web3/wallet/zcash

[image] I came across this when testing the ZEC sending feature. It looks like the font color just needs to be a bit more contrasting at least for dark mode. Also, when checking this please make sure that the addresses wrap properly or are scrollable if the text extends outside this box. In the example that I was looking at I didn't encounter this issue, but did previously with the BTC feature. We should be able to just copy what we did in there.

Timeline (11 of 14 events)
  1. 2024-02-06 11:03 Label added release-notes/exclude by kdenhartog
  2. 2024-02-06 11:03 Label added OS/Desktop by kdenhartog
  3. 2024-02-09 17:25 Label added priority/P3 by onyb
  4. 2024-06-25 18:20 Label removed release-notes/exclude by Douglashdaniel
  5. 2024-06-25 18:20 Label added QA/Yes by Douglashdaniel
  6. 2024-06-25 18:20 Label added release-notes/include by Douglashdaniel
  7. 2024-06-25 19:04 Referenced by brave-core#24375 by Douglashdaniel
  8. 2024-06-25 20:56 Closed completed brave-core#24375 by Douglashdaniel
  9. 2024-06-25 20:57 Milestone set 1.69.x - Nightly by brave-builds
  10. 2024-07-24 10:38 Label added QA Pass-Win64 by srirambv
  11. 2024-08-20 17:11 Referenced by brave-browser#40559 by LaurenWags
Pull request

brave-core#24375 style(wallet): Confirm ZCash Transaction Details Text

State: merged 2024-06-25 · created · closed · updated · discovered via search:zcash is:pr, search:zec is:pr · matched title:zcash, body:zcash

CI/storybook-url feature/web3/wallet

Description Fixes the Details dark text color when confirming a ZCash transaction Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup" commits before merge, so that history is a…

Timeline (4 of 6 events)
  1. 2024-06-25 20:56 Merged master by Douglashdaniel
  2. 2024-06-25 20:56 Closed by Douglashdaniel
  3. 2024-06-25 20:56 Milestone set 1.69.x - Nightly by github-actions
  4. 2024-07-24 10:37 Referenced by brave-browser#35827 by srirambv