Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Max send UI bug when sending ZEC

In a Release build Issue Transactions & fees

Lead item brave-browser#35825 · opened by kdenhartog · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#28343 merged 2025-04-23 into master by cypt4
    [ZCash] Handle sending max funds properly
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_35825 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.79.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: onyb · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...2a48f3a9: behind); later builds of the same history include it (brave-core#28343)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...2a48f3a9: behind); later builds of the same history include it (brave-core#28343)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...2a48f3a9: behind); later builds of the same history include it (brave-core#28343)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...2a48f3a9: behind); later builds of the same history include it (brave-core#28343)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...2a48f3a9: behind); later builds of the same history include it (brave-core#28343)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...2a48f3a9: behind); later builds of the same history include it (brave-core#28343)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...2a48f3a9: behind); later builds of the same history include it (brave-core#28343)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...2a48f3a9: behind); later builds of the same history include it (brave-core#28343)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...2a48f3a9: behind); later builds of the same history include it (brave-core#28343)

Members and their history

Issue

brave-browser#35825 [Zcash] Max send UI bug when sending ZEC

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash, search:zec · matched label:feature/web3/wallet/zcash, title:zcash

QA Pass-Win64 priority/P3 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/solana feature/web3/wallet/filecoin feature/web3/wallet/core feature/web3/wallet/zcash

This looks to be a UI bug in the same way that happened with BTC. We likely just need to remove the expected fee portion from the max send amount so that this goes through as expected. https://github.com/brave/brave-browser/assets/23125059/e0cb6fcb-369a-47a2-9683-a2fe2c1d612f

Timeline (9 of 16 events)
  1. 2024-02-06 10:49 Label added QA/Yes by kdenhartog
  2. 2024-02-06 10:49 Label added release-notes/exclude by kdenhartog
  3. 2024-02-06 10:49 Label added OS/Desktop by kdenhartog
  4. 2024-02-09 17:24 Label added priority/P3 by onyb
  5. 2024-02-26 17:38 Referenced by brave-browser#36349 by cypt4
  6. 2025-03-26 22:03 Referenced by brave-core#28343 by cypt4
  7. 2025-04-23 06:50 Closed completed brave-core#28343 by cypt4
  8. 2025-04-23 06:51 Milestone set 1.79.x - Nightly by brave-builds
  9. 2025-05-13 14:09 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#28343 [ZCash] Handle sending max funds properly

State: merged 2025-04-23 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:zcash is:pr · matched title:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/35825 Test plan: 1) Sending without using maximum amount button should work as expected 2) Sending with using maximum amount button should work as expected Cases like t->t, t->s, s->s

Timeline (5 of 11 events)
  1. 2025-04-16 11:39 Ready for review by cypt4
  2. 2025-04-23 06:50 Merged master by cypt4
  3. 2025-04-23 06:50 Closed by cypt4
  4. 2025-04-23 06:50 Milestone set 1.79.x - Nightly by github-actions
  5. 2025-05-13 14:09 Referenced by brave-browser#35825 by srirambv

Also mentioned by (not linked as fixes): brave-browser#36349