Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Individual key export button should be removed for ZEC/BTC

Closed as not planned Issue Addresses, accounts & memos

Lead item brave-browser#35824 · opened by kdenhartog · last source update

Issue state

Closed (not planned)

Closed .

Implementation

No pull request is linked by closing keywords, GitHub’s closing references, a brave_<issue> branch name or the issue timeline.

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): Desktop

Owner: unassigned

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopUnknown 1.97.59no merged PR is linked, so presence in this build is unknownUnknown 1.98.47no merged PR is linked, so presence in this build is unknownUnknown 1.100.5no merged PR is linked, so presence in this build is unknown
AndroidUnknown 1.97.57no merged PR is linked, so presence in this build is unknownUnknown 1.98.52no merged PR is linked, so presence in this build is unknownUnknown 1.100.5no merged PR is linked, so presence in this build is unknown
iOSUnknown 1.96.62no merged PR is linked, so presence in this build is unknownUnknown 1.99.44no merged PR is linked, so presence in this build is unknownUnknown 1.100.7no merged PR is linked, so presence in this build is unknown

Members and their history

Issue

brave-browser#35824 Individual key export button should be removed for ZEC/BTC

State: closed (not planned) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash, search:zec · matched label:feature/web3/wallet/zcash, title:zec, body:zec

QA/Yes release-notes/exclude closed/stale feature/web3/wallet OS/Desktop feature/web3/wallet/bitcoin feature/web3/wallet/zcash

This is an issue when attempting to export the individual keys for BTC/ZEC. Since we don't use the account model for these it doesn't really make sense to export just a single key, so I'm thinking the better solution here is to just remove this button all together. Wdyt @supermassive @cypt4 @jamesmudgett ? https://github.com/brave/brave-browser/assets/23125059/b20fb56d-8197-4d32-9641-3bb2b2d353e6

Timeline (4 of 8 events)
  1. 2024-02-06 10:48 Label added QA/Yes by kdenhartog
  2. 2024-02-06 10:48 Label added release-notes/exclude by kdenhartog
  3. 2024-02-06 10:48 Label added OS/Desktop by kdenhartog
  4. 2024-12-17 10:26 Closed not_planned by srirambv