Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Show correct error when transaction failed due existance of posted one

In a Release build Issue Transactions & fees

Lead item brave-browser#35734 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#21935 merged 2024-02-08 into master by cypt4
    Show correct error when transaction failed due existance of posted one
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_35734 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.64.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...e345d575: behind); later builds of the same history include it (brave-core#21935)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...e345d575: behind); later builds of the same history include it (brave-core#21935)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e345d575: behind); later builds of the same history include it (brave-core#21935)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...e345d575: behind); later builds of the same history include it (brave-core#21935)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...e345d575: behind); later builds of the same history include it (brave-core#21935)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e345d575: behind); later builds of the same history include it (brave-core#21935)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...e345d575: behind); later builds of the same history include it (brave-core#21935)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...e345d575: behind); later builds of the same history include it (brave-core#21935)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...e345d575: behind); later builds of the same history include it (brave-core#21935)

Members and their history

Issue

brave-browser#35734 [Zcash] Show correct error when transaction failed due existance of posted one

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

We don't have pending balance at the moment so only one outgoing transaction could be processed at point of time per account. Otherwise it would conflict with existing one due reuse of utxos. We should show obvious error saying to wait until previous transaction finishes.

Timeline (8 of 14 events)
  1. 2024-01-31 17:25 Label added OS/Android by cypt4
  2. 2024-01-31 17:25 Label added OS/Desktop by cypt4
  3. 2024-02-07 10:07 Label added QA/Yes by cypt4
  4. 2024-02-07 10:07 Label added release-notes/exclude by cypt4
  5. 2024-02-07 10:10 Referenced by brave-core#21935 by cypt4
  6. 2024-02-08 09:28 Closed completed brave-core#21935 by cypt4
  7. 2024-02-08 09:29 Milestone set 1.64.x - Nightly by brave-builds
  8. 2024-03-13 11:36 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#21935 Show correct error when transaction failed due existance of posted one

State: merged 2024-02-08 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr · matched body:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/35734 Resolves Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened…

Timeline (5 of 8 events)
  1. 2024-02-07 18:10 Ready for review by cypt4
  2. 2024-02-08 09:28 Merged master by cypt4
  3. 2024-02-08 09:28 Closed by cypt4
  4. 2024-02-08 09:29 Milestone set 1.64.x - Nightly by github-actions
  5. 2024-03-13 11:36 Referenced by brave-browser#35734 by srirambv