Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Add Zcash to supported networks list when wallet is created

In a Release build Issue General Zcash support

Lead item brave-browser#35732 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#21859 merged 2024-02-06 into master by cypt4
    Add Zcash to the onboarding supported network list
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_35732 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.64.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...3b9adeda: behind); later builds of the same history include it (brave-core#21859)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...3b9adeda: behind); later builds of the same history include it (brave-core#21859)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...3b9adeda: behind); later builds of the same history include it (brave-core#21859)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...3b9adeda: behind); later builds of the same history include it (brave-core#21859)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...3b9adeda: behind); later builds of the same history include it (brave-core#21859)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...3b9adeda: behind); later builds of the same history include it (brave-core#21859)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...3b9adeda: behind); later builds of the same history include it (brave-core#21859)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...3b9adeda: behind); later builds of the same history include it (brave-core#21859)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...3b9adeda: behind); later builds of the same history include it (brave-core#21859)

Members and their history

Issue

brave-browser#35732 [Zcash] Add Zcash to supported networks list when wallet is created

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:zcash

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Steps to reproduce: 1) Enable Zcash feature flag at the chrome://flags page 2) Create new wallet In this case there is no Zcash in the supported networks list: [image]

Timeline (8 of 14 events)
  1. 2024-01-31 17:18 Label added OS/Android by cypt4
  2. 2024-01-31 17:18 Label added OS/Desktop by cypt4
  3. 2024-02-01 12:36 Referenced by brave-core#21859 by cypt4
  4. 2024-02-06 10:50 Closed completed brave-core#21859 by cypt4
  5. 2024-02-06 10:51 Milestone set 1.64.x - Nightly by brave-builds
  6. 2024-02-06 18:03 Label added QA/Yes by cypt4
  7. 2024-02-06 18:03 Label added release-notes/exclude by cypt4
  8. 2024-03-11 11:16 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#21859 Add Zcash to the onboarding supported network list

State: merged 2024-02-06 · created · closed · updated · discovered via search:zcash is:pr, search:zec is:pr · matched title:zcash, body:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Add Zcash to the onboarding supported network list Add Zcash networks to the settings page Add wallet tests for Zcash Resolves https://github.com/brave/brave-browser/issues/35732 Test plan: With enabled Zcash feature: 1) Check Zcash is shown on the onboarding screen when wallet is created [image] 2) Check that network list contains Zcash [image] 3) Check onboarding checkbox is working correctly for Zcash 4) Check visibility settings are working correctly With disabled Zcash…

Timeline (5 of 9 events)
  1. 2024-02-01 17:33 Ready for review by cypt4
  2. 2024-02-06 10:50 Merged master by cypt4
  3. 2024-02-06 10:50 Closed by cypt4
  4. 2024-02-06 10:50 Milestone set 1.64.x - Nightly by github-actions
  5. 2024-03-11 11:16 Referenced by brave-browser#35732 by srirambv