Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Migrate tx meta database format to a one level dict

In a Release build Issue Ironwood pool & migration

Lead item brave-browser#35439 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#21644 merged 2024-01-29 into master by supermassive
    Cleanup TX db storage format
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.64.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...79ab8b56: behind); later builds of the same history include it (brave-core#21644)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...79ab8b56: behind); later builds of the same history include it (brave-core#21644)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...79ab8b56: behind); later builds of the same history include it (brave-core#21644)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...79ab8b56: behind); later builds of the same history include it (brave-core#21644)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...79ab8b56: behind); later builds of the same history include it (brave-core#21644)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...79ab8b56: behind); later builds of the same history include it (brave-core#21644)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...79ab8b56: behind); later builds of the same history include it (brave-core#21644)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...79ab8b56: behind); later builds of the same history include it (brave-core#21644)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...79ab8b56: behind); later builds of the same history include it (brave-core#21644)

Members and their history

Issue

brave-browser#35439 Migrate tx meta database format to a one level dict

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#21644

QA Pass-Win64 dev-concern QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Continuation of https://github.com/brave/brave-browser/issues/35265 We don't need tree-like structure to store transactions. {td: tx_meta} dict is enough. That also allows us to remove network_id.

Timeline (7 of 10 events)
  1. 2024-01-19 11:38 Label added QA/Yes by supermassive
  2. 2024-01-19 11:38 Label added release-notes/exclude by supermassive
  3. 2024-01-19 11:38 Label added OS/Desktop by supermassive
  4. 2024-01-19 11:39 Referenced by brave-core#21644 by supermassive
  5. 2024-01-29 08:29 Closed completed brave-core#21644 by supermassive
  6. 2024-01-29 08:30 Milestone set 1.64.x - Nightly by brave-builds
  7. 2024-03-12 10:21 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#21644 Cleanup TX db storage format

State: merged 2024-01-29 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/35439 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the…

Timeline (3 of 6 events)
  1. 2024-01-29 08:29 Merged master by supermassive
  2. 2024-01-29 08:29 Closed by supermassive
  3. 2024-01-29 08:29 Milestone set 1.64.x - Nightly by github-actions