Zcash × Brave WalletPersonal project

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Add error codes

Open Issue General Zcash support

Lead item brave-browser#35267 · opened by cypt4 · last source update

This issue is open on GitHub. Fixes sometimes land through pull requests that do not link the issue (for example a later refactor); this tracker follows only explicit links (closing references, “Resolves” lines, brave_<issue> branch names, uplifts and the issue timeline).

Issue state

Open

Open.

Implementation

No pull request is linked by closing keywords, GitHub’s closing references, a brave_<issue> branch name or the issue timeline.

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): Android, Desktop

Owner: unassigned

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopUnknown 1.97.59no merged PR is linked, so presence in this build is unknownUnknown 1.98.47no merged PR is linked, so presence in this build is unknownUnknown 1.100.5no merged PR is linked, so presence in this build is unknown
AndroidUnknown 1.97.57no merged PR is linked, so presence in this build is unknownUnknown 1.98.52no merged PR is linked, so presence in this build is unknownUnknown 1.100.5no merged PR is linked, so presence in this build is unknown
iOSUnknown 1.96.62no merged PR is linked, so presence in this build is unknownUnknown 1.99.44no merged PR is linked, so presence in this build is unknownUnknown 1.100.7no merged PR is linked, so presence in this build is unknown

Members and their history

Issue

brave-browser#35267 [ZCash] Add error codes

State: open · created · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

QA/No dev-concern release-notes/exclude OS/Android OS/Desktop feature/web3/wallet/zcash

When error occurs we should add additional error_code to the template message to specify reason more accurate. Also base::expected should be used to provide errors everywhere. SignAndPostTransactionCallback for ex.

Timeline (5 of 9 events)
  1. 2024-01-11 12:28 Label added OS/Android by cypt4
  2. 2024-01-11 12:28 Label added OS/Desktop by cypt4
  3. 2024-01-11 12:29 Label added QA/No by cypt4
  4. 2024-01-11 12:29 Label added release-notes/exclude by cypt4
  5. 2024-01-11 12:29 Referenced by brave-core#21460 by cypt4

Also mentioned by (not linked as fixes): brave-core#21460