Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] ZCash fixes

In a Release build Issue General Zcash support

Lead item brave-browser#35173 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#21506 merged 2024-01-10 into master by cypt4
    ZCash fixes
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_35173 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.63.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...6d737f23: behind); later builds of the same history include it (brave-core#21506)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...6d737f23: behind); later builds of the same history include it (brave-core#21506)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...6d737f23: behind); later builds of the same history include it (brave-core#21506)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...6d737f23: behind); later builds of the same history include it (brave-core#21506)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...6d737f23: behind); later builds of the same history include it (brave-core#21506)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...6d737f23: behind); later builds of the same history include it (brave-core#21506)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...6d737f23: behind); later builds of the same history include it (brave-core#21506)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...6d737f23: behind); later builds of the same history include it (brave-core#21506)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...6d737f23: behind); later builds of the same history include it (brave-core#21506)

Members and their history

Issue

brave-browser#35173 [ZCash] ZCash fixes

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

priority/P3 QA/No release-notes/exclude OS/Android OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

1) Crash occurs when a new account created 2) Testnet account is created as the mainnet 3) Discovery is not done when wallet is unlocked 4) Last unused address should be updated before balance check

Timeline (8 of 13 events)
  1. 2024-01-08 00:56 Label added priority/P3 by cypt4
  2. 2024-01-08 00:56 Label added OS/Android by cypt4
  3. 2024-01-08 00:56 Label added OS/Desktop by cypt4
  4. 2024-01-08 01:14 Referenced by brave-core#21506 by cypt4
  5. 2024-01-10 11:28 Closed completed brave-core#21506 by cypt4
  6. 2024-01-10 11:28 Label added QA/No by cypt4
  7. 2024-01-10 11:28 Label added release-notes/exclude by cypt4
  8. 2024-01-10 11:29 Milestone set 1.63.x - Nightly by brave-builds
Pull request

brave-core#21506 ZCash fixes

State: merged 2024-01-10 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr · matched title:zcash, body:zcash

CI/storybook-url CI/run-upstream-tests feature/web3/wallet feature/web3/wallet/core

Various Zcash related fixes: Fixed crash on account creation. Testnet acc creation fixes. Added proper subscription on wallet unlock to make account discovery. Added discovery step before balance fetching Resolves https://github.com/brave/brave-browser/issues/35173 Resolves Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used…

Timeline (4 of 8 events)
  1. 2024-01-09 07:33 Ready for review by cypt4
  2. 2024-01-10 11:28 Merged master by cypt4
  3. 2024-01-10 11:28 Closed by cypt4
  4. 2024-01-10 11:28 Milestone set 1.63.x - Nightly by github-actions