Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Remove export option for Bitcoin accounts

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#34921 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#21415 merged 2023-12-19 into master by supermassive
    Fix BTC address ui issues
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.63.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...a8355124: behind); later builds of the same history include it (brave-core#21415)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...a8355124: behind); later builds of the same history include it (brave-core#21415)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...a8355124: behind); later builds of the same history include it (brave-core#21415)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...a8355124: behind); later builds of the same history include it (brave-core#21415)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...a8355124: behind); later builds of the same history include it (brave-core#21415)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...a8355124: behind); later builds of the same history include it (brave-core#21415)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...a8355124: behind); later builds of the same history include it (brave-core#21415)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...a8355124: behind); later builds of the same history include it (brave-core#21415)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...a8355124: behind); later builds of the same history include it (brave-core#21415)

Members and their history

Issue

brave-browser#34921 Remove export option for Bitcoin accounts

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#21415

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/bitcoin

Description Remove export option for Bitcoin accounts Steps to Reproduce 1. Create wallet on Nightly 2. Create Bitcoin account 3. Go to accounts tab and select Bitcoin account 4. Click on menu, shows export option 5. Clicking it doesn't do anything Actual result: https://github.com/brave/brave-browser/assets/17010094/ebb6c8b9-52bb-4353-b5b5-8f75744b9d9d Expected result: No export option for Bitcoin account Reproduces how often: Easy Brave version (brave://version info)…

Timeline (7 of 9 events)
  1. 2023-12-15 16:05 Label added QA/Yes by srirambv
  2. 2023-12-15 16:05 Label added release-notes/exclude by srirambv
  3. 2023-12-15 16:05 Label added OS/Desktop by srirambv
  4. 2023-12-18 07:01 Referenced by brave-core#21415 by supermassive
  5. 2023-12-19 02:34 Closed completed brave-core#21415 by supermassive
  6. 2023-12-19 02:34 Milestone set 1.63.x - Nightly by brave-builds
  7. 2024-02-06 12:14 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#21415 Fix BTC address ui issues

State: merged 2023-12-19 · created · closed · updated · discovered via search:zec is:pr · matched body:zec

CI/storybook-url feature/web3/wallet

Resolves https://github.com/brave/brave-browser/issues/34926 Resolves https://github.com/brave/brave-browser/issues/34921 - Hide export account button for BTC and ZEC accounts - Fixes issues with BTC address in these cases [image] [image] - Fixes use of wrong network for explorer url for tx sent screen Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket…

Timeline (5 of 7 events)
  1. 2023-12-18 06:42 Referenced by brave-browser#34926 by supermassive
  2. 2023-12-19 02:34 Merged master by supermassive
  3. 2023-12-19 02:34 Closed by supermassive
  4. 2023-12-19 02:34 Milestone set 1.63.x - Nightly by github-actions
  5. 2024-02-06 12:14 Referenced by brave-browser#34921 by srirambv