Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Creating a Solana Transaction Causes the Browser to Crash

In a Release build Bug Security & hardening

Lead item brave-browser#34779 · opened by Douglashdaniel · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#21296 merged 2023-12-08 into master by Douglashdaniel
    fix(wallet): Solana Transaction Crash
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.63.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...9ac4193a: behind); later builds of the same history include it (brave-core#21296)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...9ac4193a: behind); later builds of the same history include it (brave-core#21296)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...9ac4193a: behind); later builds of the same history include it (brave-core#21296)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...9ac4193a: behind); later builds of the same history include it (brave-core#21296)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...9ac4193a: behind); later builds of the same history include it (brave-core#21296)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...9ac4193a: behind); later builds of the same history include it (brave-core#21296)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...9ac4193a: behind); later builds of the same history include it (brave-core#21296)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...9ac4193a: behind); later builds of the same history include it (brave-core#21296)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...9ac4193a: behind); later builds of the same history include it (brave-core#21296)

Members and their history

Issue

brave-browser#34779 Creating a Solana Transaction Causes the Browser to Crash

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#21296

bug QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop front-end-change

Description Creating a Solana transaction in the Wallet causes the Browser to crash Steps to Reproduce 1. Open the Wallet and create a Solana transaction 2. The Browser will crash after clicking Send Actual result: https://github.com/brave/brave-browser/assets/40611140/2fc17d51-e316-4b9a-8311-53bf90add91d Expected result: Should not crash the Browser Reproduces how often: Brave version (brave://version info) Version/Channel Information: - Can you reproduce this issue with…

Timeline (7 of 10 events)
  1. 2023-12-07 22:57 Label added QA/Yes by Douglashdaniel
  2. 2023-12-07 22:57 Label added release-notes/exclude by Douglashdaniel
  3. 2023-12-07 22:57 Label added OS/Desktop by Douglashdaniel
  4. 2023-12-07 23:00 Referenced by brave-core#21296 by Douglashdaniel
  5. 2023-12-08 01:20 Closed completed brave-core#21296 by Douglashdaniel
  6. 2023-12-08 01:20 Milestone set 1.63.x - Nightly by brave-builds
  7. 2024-02-16 05:41 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#21296 fix(wallet): Solana Transaction Crash

State: merged 2023-12-08 · created · closed · updated · discovered via search:zec is:pr · matched body:zec

CI/storybook-url feature/web3/wallet

Description Fixes a bug where when creating a Solana transaction, it would also try to create a ZEC transaction causing the Browser to crash. Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review…

Timeline (4 of 6 events)
  1. 2023-12-08 01:20 Merged master by Douglashdaniel
  2. 2023-12-08 01:20 Closed by Douglashdaniel
  3. 2023-12-08 01:20 Milestone set 1.63.x - Nightly by github-actions
  4. 2024-02-16 05:41 Referenced by brave-browser#34779 by srirambv