Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Replace `absl::optional` uses with `std::optional`

In a Release build Issue General Zcash support

Lead item brave-browser#34638 · opened by cdesouza-chromium · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#21156 merged 2023-12-01 into master by cdesouza-chromium
    [CodeHealth] Replace `absl::optional` with `std::*`
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.63.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cdesouza-chromium · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...d1384a78: behind); later builds of the same history include it (brave-core#21156)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...d1384a78: behind); later builds of the same history include it (brave-core#21156)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...d1384a78: behind); later builds of the same history include it (brave-core#21156)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...d1384a78: behind); later builds of the same history include it (brave-core#21156)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...d1384a78: behind); later builds of the same history include it (brave-core#21156)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...d1384a78: behind); later builds of the same history include it (brave-core#21156)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...d1384a78: behind); later builds of the same history include it (brave-core#21156)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...d1384a78: behind); later builds of the same history include it (brave-core#21156)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...d1384a78: behind); later builds of the same history include it (brave-core#21156)

Members and their history

Issue

brave-browser#34638 Replace `absl::optional` uses with `std::optional`

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#21156

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Upstream has turned absl::optional into a polyfill for std::optional. We should make sure we go ahead and remove all uses of absl::optional.

Timeline (6 of 9 events)
  1. 2023-11-30 03:59 Label added OS/Desktop by cdesouza-chromium
  2. 2023-11-30 03:59 Label added QA/No by cdesouza-chromium
  3. 2023-11-30 03:59 Label added release-notes/exclude by cdesouza-chromium
  4. 2023-11-30 03:59 Referenced by brave-core#21156 by cdesouza-chromium
  5. 2023-12-01 10:16 Closed completed brave-core#21156 by cdesouza-chromium
  6. 2023-12-01 10:16 Milestone set 1.63.x - Nightly by brave-builds
Pull request

brave-core#21156 [CodeHealth] Replace `absl::optional` with `std::*`

State: merged 2023-12-01 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

CI/run-network-audit needs-security-review feature/web3/wallet feature/web3/wallet/core

This change replaces all uses of absl::optional with std:: variants for optional. This is in line with upstream recent changes making absl::optional a polyfill to the std type. This change has been done using automation, and should have no functional effect: #!/bin/bash function replace { echo "Replacing $1 by $2" git grep -l "$1" \ | cut -f1 -d: \ | sort \ | uniq \ | grep \ -e "\.h" \ -e "\.cc" \ -e "\.mm" \ -e "\.py" \ | xargs sed -i "s/$1/$2/g" } function…

Timeline (4 of 8 events)
  1. 2023-11-30 07:51 Ready for review by cdesouza-chromium
  2. 2023-12-01 10:16 Merged master by cdesouza-chromium
  3. 2023-12-01 10:16 Closed by cdesouza-chromium
  4. 2023-12-01 10:16 Milestone set 1.63.x - Nightly by github-actions