Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash]Isolate GRPC validation into separate process

In a Release build Issue Security & hardening

Lead item brave-browser#34561 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#21627 merged 2024-01-29 into master by cypt4
    Move Zcash protobuf parsing to separate process
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_34561 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.64.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...5b8ea34b: behind); later builds of the same history include it (brave-core#21627)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...5b8ea34b: behind); later builds of the same history include it (brave-core#21627)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...5b8ea34b: behind); later builds of the same history include it (brave-core#21627)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...5b8ea34b: behind); later builds of the same history include it (brave-core#21627)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...5b8ea34b: behind); later builds of the same history include it (brave-core#21627)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...5b8ea34b: behind); later builds of the same history include it (brave-core#21627)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...5b8ea34b: behind); later builds of the same history include it (brave-core#21627)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...5b8ea34b: behind); later builds of the same history include it (brave-core#21627)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...5b8ea34b: behind); later builds of the same history include it (brave-core#21627)

Members and their history

Issue

brave-browser#34561 [ZCash]Isolate GRPC validation into separate process

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:zcash

QA/No release-notes/exclude feature/web3/wallet OS/Android OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Same thing we are doing in the ApiRequestHelper needs to be implemented when we process GRPC for Zcash.

Timeline (8 of 12 events)
  1. 2023-11-28 07:24 Label added OS/Android by cypt4
  2. 2023-11-28 07:24 Label added OS/Desktop by cypt4
  3. 2023-11-28 07:24 Referenced by brave-core#20895 by cypt4
  4. 2024-01-18 18:06 Referenced by brave-core#21627 by cypt4
  5. 2024-01-29 20:26 Closed completed brave-core#21627 by cypt4
  6. 2024-01-29 20:27 Milestone set 1.64.x - Nightly by brave-builds
  7. 2024-01-31 17:13 Label added QA/No by cypt4
  8. 2024-01-31 17:13 Label added release-notes/exclude by cypt4
Pull request

brave-core#21627 Move Zcash protobuf parsing to separate process

State: merged 2024-01-29 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr · matched title:zcash, body:zcashdecoder

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Introduces BraveWalletUtilsService which is able to provide ZCashDecoder to convert protobufs to mojo structs and pass them to the main process. Resolves https://github.com/brave/brave-browser/issues/34561 Upd. : Updated folder structure according review - components/brave_wallet/common/proto/ - zcash protobufs are placed in common dir since they are needed for constructing outgoing messages too - components/services/brave_wallet/public/cpp/ - contains in process launcher…

Timeline (5 of 10 events)
  1. 2024-01-23 13:11 Ready for review by cypt4
  2. 2024-01-29 20:26 Merged master by cypt4
  3. 2024-01-29 20:26 Closed by cypt4
  4. 2024-01-29 20:26 Milestone set 1.64.x - Nightly by github-actions
  5. 2025-07-22 22:48 Referenced by brave-browser#47850 by kdenhartog

Also mentioned by (not linked as fixes): brave-core#20895