Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Remove NFT tabs for Filecoin/BTC/ZEC coins

In release notes Bug General Zcash support

Lead item brave-browser#33992 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#20734 merged 2023-10-30 into master by Douglashdaniel
    fix(wallet): Remove NFTs Tab for Certain CoinTypes
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.62.153: “Removed "NFT" tab for Filecoin account view. (#33992)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)
  • QA Pass-macOS (Desktop only)
  • QA Pass-Linux (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.62.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...78934b57: behind); later builds of the same history include it (brave-core#20734)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...78934b57: behind); later builds of the same history include it (brave-core#20734)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...78934b57: behind); later builds of the same history include it (brave-core#20734)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...78934b57: behind); later builds of the same history include it (brave-core#20734)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...78934b57: behind); later builds of the same history include it (brave-core#20734)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...78934b57: behind); later builds of the same history include it (brave-core#20734)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...78934b57: behind); later builds of the same history include it (brave-core#20734)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...78934b57: behind); later builds of the same history include it (brave-core#20734)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...78934b57: behind); later builds of the same history include it (brave-core#20734)

Members and their history

Issue

brave-browser#33992 Remove NFT tabs for Filecoin/BTC/ZEC coins

State: closed (completed) · created · closed · updated · discovered via search:zec · matched title:zec, body:zec

bug QA Pass-Win64 QA Pass-macOS QA Pass-Linux QA/Yes release-notes/include feature/web3/wallet OS/Desktop front-end-change

Description Remove NFT tabs for Filecoin/BTC/ZEC coins Steps to Reproduce 1. Open Filecoin Account 2. Shows NFT tab Actual result: [image] Expected result: Shouldn't show NFT tab for Filecoin/BTC/ZEC coins Reproduces how often: Easy Brave version (brave://version info) All Version/Channel Information: - Can you reproduce this issue with the current release? NA - Can you reproduce this issue with the beta channel? Yes - Can you reproduce this issue with the nightly channel?…

Timeline (10 of 13 events)
  1. 2023-10-30 10:36 Label added QA/Yes by srirambv
  2. 2023-10-30 10:36 Label added release-notes/include by srirambv
  3. 2023-10-30 10:36 Label added OS/Desktop by srirambv
  4. 2023-10-30 14:05 Referenced by brave-core#20734 by Douglashdaniel
  5. 2023-10-30 16:01 Closed completed brave-core#20734 by Douglashdaniel
  6. 2023-10-30 16:01 Milestone set 1.62.x - Nightly by brave-builds
  7. 2024-01-03 11:39 Label added QA Pass-Win64 by srirambv
  8. 2024-01-03 11:39 Label added QA Pass-macOS by srirambv
  9. 2024-01-03 11:39 Label added QA Pass-Linux by srirambv
  10. 2024-01-24 13:59 Referenced by brave-browser#35541 by LaurenWags
Pull request

brave-core#20734 fix(wallet): Remove NFTs Tab for Certain CoinTypes

State: merged 2023-10-30 · created · closed · updated · discovered via linked:brave/brave-browser#33992

CI/storybook-url feature/web3/wallet

Description Fixes a bug where we were showing the NFTs tab on the Account Details page for CoinTypes that don't support NFTs. Resolves Submitter Checklist: - [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [x] There is a ticket for my issue - [x] Used Github auto-closing keywords in the PR description above - [x] Wrote a good PR/commit description - [x] Squashed any review feedback or "fixup"…

Timeline (4 of 6 events)
  1. 2023-10-30 16:01 Merged master by Douglashdaniel
  2. 2023-10-30 16:01 Closed by Douglashdaniel
  3. 2023-10-30 16:01 Milestone set 1.62.x - Nightly by github-actions
  4. 2024-01-03 11:38 Referenced by brave-browser#33992 by srirambv