Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Implement ZCash transparent tx creation and signing

In a Release build Issue Transactions & fees

Lead item brave-browser#33661 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#20895 merged 2023-11-29 into master by cypt4
    Implement ZCash transparent tx signing
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_33661 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.62.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...8c95bd6e: behind); later builds of the same history include it (brave-core#20895)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...8c95bd6e: behind); later builds of the same history include it (brave-core#20895)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8c95bd6e: behind); later builds of the same history include it (brave-core#20895)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...8c95bd6e: behind); later builds of the same history include it (brave-core#20895)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...8c95bd6e: behind); later builds of the same history include it (brave-core#20895)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8c95bd6e: behind); later builds of the same history include it (brave-core#20895)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...8c95bd6e: behind); later builds of the same history include it (brave-core#20895)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...8c95bd6e: behind); later builds of the same history include it (brave-core#20895)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...8c95bd6e: behind); later builds of the same history include it (brave-core#20895)

Members and their history

Issue

brave-browser#33661 [ZCash] Implement ZCash transparent tx creation and signing

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

QA/No release-notes/exclude feature/web3/wallet OS/Android OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

According https://zips.z.cash/zip-0244 https://zips.z.cash/zip-0225

Timeline (7 of 11 events)
  1. 2023-10-16 17:22 Label added OS/Android by cypt4
  2. 2023-10-16 17:22 Label added OS/Desktop by cypt4
  3. 2023-11-08 15:12 Referenced by brave-core#20895 by cypt4
  4. 2023-11-29 15:01 Closed completed brave-core#20895 by cypt4
  5. 2023-11-29 15:02 Milestone set 1.62.x - Nightly by brave-builds
  6. 2023-12-22 17:05 Label added QA/No by cypt4
  7. 2024-01-05 21:44 Label added release-notes/exclude by cypt4
Pull request

brave-core#20895 Implement ZCash transparent tx signing

State: merged 2023-11-29 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr, search:zec is:pr · matched title:zcash, body:zcash

CI/storybook-url CI/run-upstream-tests feature/web3/wallet feature/web3/wallet/core

Implement ZCash transparent tx signing Resolves https://github.com/brave/brave-browser/issues/33661 Tx id digest and signature per-input digest is calculated via https://zips.z.cash/zip-0244. Calculation is implemented in ZCashSerializer. Nu5 Tx format https://zips.z.cash/zip-0225. Implemented in ZCashSerializer::SerializeRawTransaction. Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have…

Timeline (4 of 10 events)
  1. 2023-11-08 20:51 Ready for review by cypt4
  2. 2023-11-29 15:01 Merged master by cypt4
  3. 2023-11-29 15:01 Closed by cypt4
  4. 2023-11-29 15:01 Milestone set 1.62.x - Nightly by github-actions