Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Remove wallet's KeyringInfo

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#33563 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#20488 merged 2023-10-20 into master by supermassive
    Remove mojo KeyringInfo and lazy keyrings
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.61.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...6b1d38c4: behind); later builds of the same history include it (brave-core#20488)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...6b1d38c4: behind); later builds of the same history include it (brave-core#20488)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...6b1d38c4: behind); later builds of the same history include it (brave-core#20488)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...6b1d38c4: behind); later builds of the same history include it (brave-core#20488)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...6b1d38c4: behind); later builds of the same history include it (brave-core#20488)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...6b1d38c4: behind); later builds of the same history include it (brave-core#20488)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...6b1d38c4: behind); later builds of the same history include it (brave-core#20488)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...6b1d38c4: behind); later builds of the same history include it (brave-core#20488)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...6b1d38c4: behind); later builds of the same history include it (brave-core#20488)

Members and their history

Issue

brave-browser#33563 Remove wallet's KeyringInfo

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#20488

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Timeline (7 of 10 events)
  1. 2023-10-11 08:42 Label added QA/No by supermassive
  2. 2023-10-11 08:42 Label added OS/Desktop by supermassive
  3. 2023-10-11 08:44 Referenced by brave-core#20488 by supermassive
  4. 2023-10-16 14:41 Referenced by brave/brave-ios#8252 by StephenHeaps
  5. 2023-10-20 03:00 Closed completed brave-core#20488 by supermassive
  6. 2023-10-20 03:01 Milestone set 1.61.x - Nightly by brave-builds
  7. 2023-10-23 05:28 Label added release-notes/exclude by supermassive
Pull request

brave-core#20488 Remove mojo KeyringInfo and lazy keyrings

State: merged 2023-10-20 · created · closed · updated · discovered via search:zcash is:pr · matched body:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/33563 - Removed mojo KeyringInfo. - Removed internal concept of lazy keyrings. Now when wallet is unlocked we resume all known keyrings. This allows easy enabling of new coins(like bitcoin or zcash) for existing wallets. Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used…

Timeline (3 of 8 events)
  1. 2023-10-20 03:00 Merged master by supermassive
  2. 2023-10-20 03:00 Closed by supermassive
  3. 2023-10-20 03:01 Milestone set 1.61.x - Nightly by github-actions