Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Implement Orchard Keyring

In a Release build Issue Shielded (Orchard) support

Lead item brave-browser#32303 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#23383 merged 2024-05-06 into master by cypt4
    Re-land zcash keyring support
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description
  • brave-core#22870 merged 2024-04-30 into master by cypt4
    Add Orchard support to Zcash keyring
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description
  • brave-core#22396 closed without merge into master by cypt4
    Orchard keyring
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_32303 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.67.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...f5dc515f: behind); later builds of the same history include it (brave-core#23383)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...f5dc515f: behind); later builds of the same history include it (brave-core#23383)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...f5dc515f: behind); later builds of the same history include it (brave-core#23383)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...f5dc515f: behind); later builds of the same history include it (brave-core#23383)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...f5dc515f: behind); later builds of the same history include it (brave-core#23383)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...f5dc515f: behind); later builds of the same history include it (brave-core#23383)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...f5dc515f: behind); later builds of the same history include it (brave-core#23383)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...f5dc515f: behind); later builds of the same history include it (brave-core#23383)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...f5dc515f: behind); later builds of the same history include it (brave-core#23383)

Members and their history

Issue

brave-browser#32303 [ZCash] Implement Orchard Keyring

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, title:orchard

priority/P3 QA/No release-notes/exclude feature/web3/wallet OS/Android OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Timeline (10 of 15 events)
  1. 2023-08-16 18:18 Label added OS/Android by cypt4
  2. 2023-08-16 18:18 Label added OS/Desktop by cypt4
  3. 2024-02-29 14:19 Referenced by brave-core#22396 by cypt4
  4. 2024-04-02 10:05 Referenced by brave-core#22870 by cypt4
  5. 2024-04-19 13:08 Label added priority/P3 by cypt4
  6. 2024-04-30 14:50 Closed completed brave-core#22870 by cypt4
  7. 2024-04-30 14:50 Milestone set 1.67.x - Nightly by brave-builds
  8. 2024-05-06 16:15 Referenced by brave-core#23383 by bridiver
  9. 2024-05-13 16:03 Label added QA/No by cypt4
  10. 2024-05-13 16:03 Label added release-notes/exclude by cypt4
Pull request

brave-core#23383 Re-land zcash keyring support

State: merged 2024-05-06 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr · matched title:zcash

CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/32303 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the…

Timeline (3 of 7 events)
  1. 2024-05-06 16:16 Merged master by bridiver
  2. 2024-05-06 16:16 Closed by bridiver
  3. 2024-05-06 16:17 Milestone set 1.67.x - Nightly by github-actions
Pull request

brave-core#22870 Add Orchard support to Zcash keyring

State: merged 2024-04-30 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr, search:zec is:pr · matched title:zcash, title:orchard, body:zcashkeyring

CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/32303 Pr targets brave_36128 until it is merged Adds Orchard key generation to the ZCashKeyring. Orchard keys are generated using Orchard crate. Orchard uses different keys generation strategy described here. ExtendedSpendingKey is a sort of account private key. Using this key we can generate public or internal address then. Also added orchard address support to Unified Addresses . Now we can generate address string…

Timeline (9 of 13 events)
  1. 2024-04-22 18:19 Referenced by brave-browser#37771 by cypt4
  2. 2024-04-25 11:51 Referenced by brave-browser#37856 by cypt4
  3. 2024-04-25 11:54 Referenced by brave-browser#37857 by cypt4
  4. 2024-04-25 12:00 Referenced by brave-browser#37858 by cypt4
  5. 2024-04-30 14:50 Merged master by cypt4
  6. 2024-04-30 14:50 Closed by cypt4
  7. 2024-04-30 14:50 Milestone set 1.67.x - Nightly by github-actions
  8. 2024-11-28 02:42 Referenced by brave-core#26469 by supermassive
  9. 2025-07-03 11:42 Referenced by brave-browser#44747 by cypt4
Pull request

brave-core#22396 Orchard keyring

State: closed without merge · created · closed · updated · discovered via search:orchard is:pr · matched title:orchard, body:orchard

CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core

Based on Orchard crate support https://github.com/brave/brave-core/pull/22097 Resolves https://github.com/brave/brave-browser/issues/32303 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or…

Timeline (2 of 5 events)
  1. 2024-04-01 13:05 Ready for review by cypt4
  2. 2024-04-01 13:06 Closed by cypt4