Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Implement Unifier interface

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#32239 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#21574 merged 2024-01-29 into master by cypt4
    Implement unified addresses for Zcash
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_32239_1 (weaker evidence; titles share a keyword)
  • brave-core#21460 merged 2024-01-12 into master by cypt4
    Unified Addresses support
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_32239 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.63.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...71d83350: behind); later builds of the same history include it (brave-core#21574)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...71d83350: behind); later builds of the same history include it (brave-core#21574)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...71d83350: behind); later builds of the same history include it (brave-core#21574)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...71d83350: behind); later builds of the same history include it (brave-core#21574)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...71d83350: behind); later builds of the same history include it (brave-core#21574)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...71d83350: behind); later builds of the same history include it (brave-core#21574)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...71d83350: behind); later builds of the same history include it (brave-core#21574)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...71d83350: behind); later builds of the same history include it (brave-core#21574)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...71d83350: behind); later builds of the same history include it (brave-core#21574)

Members and their history

Issue

brave-browser#32239 [ZCash] Implement Unifier interface

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:zcashrustlib

QA/No release-notes/exclude feature/web3/wallet OS/Android OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Implement Encode\Decode methods https://zips.z.cash/zip-0316 We can try to reuse code from zcashrustlib https://github.com/zcash/librustzcash/blob/d25f2bd6abf911ac36fba8340c72336a69fcb701/components/zcash_address/src/kind/unified/address.rs https://github.com/zcash/librustzcash/blob/d25f2bd6abf911ac36fba8340c72336a69fcb701/components/zcash_address/src/kind/unified/fvk.rs As was implemented here…

Timeline (10 of 14 events)
  1. 2023-08-14 19:37 Label added OS/Android by cypt4
  2. 2023-08-14 19:37 Label added OS/Desktop by cypt4
  3. 2023-12-25 12:37 Referenced by brave-core#21460 by cypt4
  4. 2024-01-12 07:14 Closed completed brave-core#21460 by cypt4
  5. 2024-01-12 07:14 Milestone set 1.63.x - Nightly by brave-builds
  6. 2024-01-12 08:13 Label added QA/No by cypt4
  7. 2024-01-12 08:13 Label added release-notes/exclude by cypt4
  8. 2024-01-14 17:24 Referenced by brave-core#21574 by cypt4
  9. 2024-01-14 19:43 Reopened by cypt4
  10. 2024-01-29 09:29 Closed completed brave-core#21574 by cypt4
Pull request

brave-core#21574 Implement unified addresses for Zcash

State: merged 2024-01-29 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr · matched title:zcash, title:unified addresses

CI/run-audit-deps CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/32239 Same implementation as in https://github.com/brave/brave-core/pull/21460 but rust bech32 library is used instead of patched bitcoin-core Bech32 lib sec review: [GitHub link omitted] Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the…

Timeline (3 of 10 events)
  1. 2024-01-29 09:29 Merged master by cypt4
  2. 2024-01-29 09:29 Closed by cypt4
  3. 2024-01-29 09:29 Milestone set 1.64.x - Nightly by github-actions
Pull request

brave-core#21460 Unified Addresses support

State: merged 2024-01-12 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:zcash is:pr · matched title:unified addresses

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/32239 Resolves Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened…

Timeline (6 of 12 events)
  1. 2023-12-29 20:35 Ready for review by cypt4
  2. 2024-01-12 07:14 Merged master by cypt4
  3. 2024-01-12 07:14 Closed by cypt4
  4. 2024-01-12 07:14 Milestone set 1.63.x - Nightly by github-actions
  5. 2024-01-12 12:36 Referenced by brave-core#21567 by cypt4
  6. 2024-01-14 17:26 Referenced by brave-core#21574 by cypt4