brave-core#19199merged 2023-07-14 into master by dependabot Bump protobufjs and trezor-connect Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description
QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.
Target
1.56.x - Release
For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.
Platforms (OS labels): Desktop
Owner: onyb, cypt4 · PR authors: dependabot, onyb
Build presence
Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.
Platform
Release
Beta
Nightly
Desktop
Included1.97.59in v1.96.61 (GitHub compare v1.96.61...c2cf5e90: behind); later builds of the same history include it (brave-core#19199)
Included1.98.47in v1.96.61 (GitHub compare v1.96.61...c2cf5e90: behind); later builds of the same history include it (brave-core#19199)
Included1.100.5in v1.96.61 (GitHub compare v1.96.61...c2cf5e90: behind); later builds of the same history include it (brave-core#19199)
Android
Included1.97.57in v1.96.61 (GitHub compare v1.96.61...c2cf5e90: behind); later builds of the same history include it (brave-core#19199)
Included1.98.52in v1.96.61 (GitHub compare v1.96.61...c2cf5e90: behind); later builds of the same history include it (brave-core#19199)
Included1.100.5in v1.96.61 (GitHub compare v1.96.61...c2cf5e90: behind); later builds of the same history include it (brave-core#19199)
iOS
Included1.96.62in v1.96.61 (GitHub compare v1.96.61...c2cf5e90: behind); later builds of the same history include it (brave-core#19199)
Included1.99.44in v1.96.61 (GitHub compare v1.96.61...c2cf5e90: behind); later builds of the same history include it (brave-core#19199)
Included1.100.7in v1.96.61 (GitHub compare v1.96.61...c2cf5e90: behind); later builds of the same history include it (brave-core#19199)
Bump versions of trezor-connect and protobufjs to fix a high-severity audit issue. |Audit issue| https://github.com/brave/brave-core/security/dependabot/54| -|- Test plan Ensure that you can continue to do the following actions using your Trezor device (testing with either One or T is enough): - able to connect - able to create account managed by Trezor - able to create and sign a simple transaction
Timeline (14 of 17 events)
2023-07-14 05:52 Label added priority/P2by onyb
2023-07-14 05:52 Label added OS/Desktopby onyb
2023-07-14 05:52 Milestone set 1.58.x - Nightlyby onyb
Resolves https://github.com/brave/brave-browser/issues/31633 Removes protobufjs. It's no longer used after updating ancestor dependency trezor-connect. These dependencies need to be updated together. Removes protobufjs Updates trezor-connect from 8.2.6-extended to 8.2.12 Changelog Sourced from trezor-connect's changelog . 8.2.12 Deprecation: update readme and add a console.log with deprecation warning Update @trezor/connect-common (fw 2.5.3) 8.2.11 Update…
Timeline (14 of 19 events)
2023-07-10 16:58 Referenced by brave-core#19201 by petemill
2023-07-13 23:09 Referenced by brave-core#19277 by bsclifton
2023-07-14 03:47 Merged masterby onyb
2023-07-14 03:47 Closed by onyb
2023-07-14 03:47 Milestone set 1.58.x - Nightlyby github-actions
Uplift of #19199 Resolves https://github.com/brave/brave-browser/issues/31633 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…
Timeline (3 of 6 events)
2023-07-14 04:10 Milestone set 1.57.x - Betaby onyb
2023-07-14 15:58 Merged 1.57.xby srirambv
2023-07-14 15:58 Closed by srirambv
Uplift PR → 1.56.x
brave-core#19289 Bump protobufjs and trezor-connect (uplift to 1.56.x)
State: merged 2023-07-14 · created · closed · updated · discovered via mentions:brave/brave-core#19199
Uplift of #19199 Resolves https://github.com/brave/brave-browser/issues/31633 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…
Timeline (3 of 6 events)
2023-07-14 04:24 Milestone set 1.56.x - Releaseby onyb